From f63197fe48af066006b12976afc37ba3631d422c Mon Sep 17 00:00:00 2001
From: simonredfern <simon@tesobe.com>
Date: Sat, 27 Dec 2025 06:29:30 +0100
Subject: [PATCH] TODO in RateLimitingUtil.scala

---
 .../src/main/scala/code/api/util/RateLimitingUtil.scala   | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/obp-api/src/main/scala/code/api/util/RateLimitingUtil.scala b/obp-api/src/main/scala/code/api/util/RateLimitingUtil.scala
index e406786b1..25179a2b6 100644
--- a/obp-api/src/main/scala/code/api/util/RateLimitingUtil.scala
+++ b/obp-api/src/main/scala/code/api/util/RateLimitingUtil.scala
@@ -151,6 +151,14 @@ object RateLimitingUtil extends MdcLoggable {
         (limit) match {
           case l if l > 0 => // Redis is available and limit is set
             val key = createUniqueKey(consumerKey, period)
+            // TODO: Check if we can remove redundant EXISTS check. GET returns None when key does not exist.
+            // Check This would reduce Redis operations from 2 to 1 (25% reduction per request).
+            // Simplified code:
+            //   val currentValue = Redis.use(JedisMethod.GET, key)
+            //   currentValue match {
+            //     case Some(value) => value.toLong + 1 <= limit
+            //     case None => true  // Key does not exist, first call
+            //   }
             val exists = Redis.use(JedisMethod.EXISTS,key).map(_.toBoolean).get
             exists match {
               case true =>