From ebb7d545640bdf3ab8944833b7d25eb21d411c4f Mon Sep 17 00:00:00 2001 From: Hongwei Date: Wed, 21 Dec 2022 15:11:28 +0100 Subject: [PATCH] refactor/tweak the role name to CanGetApiCollectionsForUser --- obp-api/src/main/scala/code/api/util/ApiRole.scala | 4 ++-- obp-api/src/main/scala/code/api/v4_0_0/APIMethods400.scala | 2 +- .../src/test/scala/code/api/v4_0_0/ApiCollectionTest.scala | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/obp-api/src/main/scala/code/api/util/ApiRole.scala b/obp-api/src/main/scala/code/api/util/ApiRole.scala index 291c2461f..6d830fe84 100644 --- a/obp-api/src/main/scala/code/api/util/ApiRole.scala +++ b/obp-api/src/main/scala/code/api/util/ApiRole.scala @@ -323,8 +323,8 @@ object ApiRole { case class CanGetApiCollection(requiresBankId: Boolean = false) extends ApiRole lazy val canGetApiCollection = CanGetApiCollection() - case class CanGetAllApiCollectionsForUser(requiresBankId: Boolean = false) extends ApiRole - lazy val canGetAllApiCollectionsForUser = CanGetAllApiCollectionsForUser() + case class CanGetApiCollectionsForUser(requiresBankId: Boolean = false) extends ApiRole + lazy val canGetApiCollectionsForUser = CanGetApiCollectionsForUser() case class CanGetAllApiCollections(requiresBankId: Boolean = false) extends ApiRole lazy val canGetAllApiCollections = CanGetAllApiCollections() diff --git a/obp-api/src/main/scala/code/api/v4_0_0/APIMethods400.scala b/obp-api/src/main/scala/code/api/v4_0_0/APIMethods400.scala index 5ef2820f8..78701422e 100644 --- a/obp-api/src/main/scala/code/api/v4_0_0/APIMethods400.scala +++ b/obp-api/src/main/scala/code/api/v4_0_0/APIMethods400.scala @@ -9065,7 +9065,7 @@ trait APIMethods400 { UnknownError ), List(apiTagApiCollection, apiTagNewStyle), - Some(canGetAllApiCollectionsForUser :: Nil) + Some(canGetApiCollectionsForUser :: Nil) ) lazy val getApiCollectionsForUser: OBPEndpoint = { diff --git a/obp-api/src/test/scala/code/api/v4_0_0/ApiCollectionTest.scala b/obp-api/src/test/scala/code/api/v4_0_0/ApiCollectionTest.scala index 363ef1a14..c621658d2 100644 --- a/obp-api/src/test/scala/code/api/v4_0_0/ApiCollectionTest.scala +++ b/obp-api/src/test/scala/code/api/v4_0_0/ApiCollectionTest.scala @@ -232,7 +232,7 @@ class ApiCollectionTest extends V400ServerSetup { responseApiEndpoint6.body.toString contains(s"$UserHasMissingRoles") should be (true) Then("grant the role and test it again") - Entitlement.entitlement.vend.addEntitlement("", resourceUser1.userId, ApiRole.canGetAllApiCollectionsForUser.toString) + Entitlement.entitlement.vend.addEntitlement("", resourceUser1.userId, ApiRole.canGetApiCollectionsForUser.toString) val responseApiEndpoint6WithRole = makeGetRequest(requestApiEndpoint6) Then("We should get a 200")