artin/OBP-API
1
0
Fork 0
mirror of https://github.com/OpenBankProject/OBP-API.git synced 2026-02-06 16:36:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't allow payments between accounts with different currencies

Browse Source
This commit is contained in:
Everett Sochowski 2014-04-11 10:20:44 +02:00
parent d2498e0bc9
commit d252f3a384
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/main/scala/code/api/1_2_1/OBPAPI1.2.1.scala
View File

@ -989,10 +989,13 @@ def checkIfLocationPossible(lat:Double,lon:Double) : Box[Unit] = {
view <- View.fromUrl(viewId, fromAccount) ?~ s"view $viewId not found"//TODO: this isn't actually used, unlike for GET transactions
makeTransJson <- tryo{json.extract[MakeTransactionJson]} ?~ {"wrong json format"}
toAccount <- {
BankAccount(makeTransJson.bank_id, makeTransJson.account_id) ?~! {"Transaction 'to' party with " +
BankAccount(makeTransJson.bank_id, makeTransJson.account_id) ?~! {"Intended recipient with " +
s" account id ${makeTransJson.account_id} at bank ${makeTransJson.bank_id}" +
" not found on the open bank project"}
" not found"}
}
sameCurrency <- booleanToBox(fromAccount.currency == toAccount.currency, {
s"Cannot send payment to account with differency currency (From ${fromAccount.currency} to ${toAccount.currency}"
})
rawAmt <- tryo {BigDecimal(makeTransJson.amount)} ?~! "amount not convertable to number"//TODO: this completely ignores currency
isPositiveAmtToSend <- booleanToBox(rawAmt > BigDecimal("0"), "Can't send a payment with a value of 0 or less")
} yield {