artin/OBP-API
1
0
Fork 0
mirror of https://github.com/OpenBankProject/OBP-API.git synced 2026-02-06 13:07:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor/removed getTransactionRequestStatusesImpl

Browse Source
This commit is contained in:
hongwei 2024-10-22 18:20:31 +02:00
parent 9add6e6703
commit cb9d9cc936
3 changed files with 2 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
obp-api/src/main/scala/code/bankconnectors/Connector.scala
View File

@ -877,16 +877,9 @@ trait Connector extends MdcLoggable {
def getTransactionRequests(initiator : User, fromAccount : BankAccount, callContext: Option[CallContext]) : Box[List[TransactionRequest]] =
LocalMappedConnector.getTransactionRequests(initiator : User, fromAccount : BankAccount, callContext: Option[CallContext])
def getTransactionRequests210(initiator : User, fromAccount : BankAccount, callContext: Option[CallContext]) : Box[(List[TransactionRequest], Option[CallContext])] = Failure(setUnimplementedError(nameOf(getTransactionRequestStatusesImpl _)))
def getTransactionRequests210(initiator : User, fromAccount : BankAccount, callContext: Option[CallContext]) : Box[(List[TransactionRequest], Option[CallContext])] = Failure(setUnimplementedError(nameOf(getTransactionRequests210 _)))
def getTransactionRequestStatuses() : Box[TransactionRequestStatus] = {
for {
transactionRequestStatuses <- getTransactionRequestStatusesImpl()
} yield transactionRequestStatuses
}
protected def getTransactionRequestStatusesImpl() : Box[TransactionRequestStatus] = Failure(setUnimplementedError(nameOf(getTransactionRequestStatusesImpl _)))
def getTransactionRequestStatuses() : Box[TransactionRequestStatus] = Failure(setUnimplementedError(nameOf(getTransactionRequestStatuses _)))
def getTransactionRequestImpl(transactionRequestId: TransactionRequestId, callContext: Option[CallContext]): Box[(TransactionRequest, Option[CallContext])] = TransactionRequests.transactionRequestProvider.vend.getTransactionRequest(transactionRequestId).map(transactionRequest =>(transactionRequest, callContext))

11
obp-api/src/main/scala/code/bankconnectors/LocalMappedConnector.scala
View File

@ -2121,11 +2121,6 @@ object LocalMappedConnector extends Connector with MdcLoggable {
callContext: Option[CallContext]): OBPReturnType[Box[CancelPayment]] = Future {
(Full(CancelPayment(true, Some(true))), callContext)
}
/*
Transaction Requests
*/
override def getTransactionRequestStatusesImpl(): Box[TransactionRequestStatus] = Empty
override def saveTransactionRequestStatusImpl(transactionRequestId: TransactionRequestId, status: String): Box[Boolean] = {
TransactionRequests.transactionRequestProvider.vend.saveTransactionRequestStatusImpl(transactionRequestId, status)
@ -4950,12 +4945,6 @@ object LocalMappedConnector extends Connector with MdcLoggable {
transactionRequestsNew.map(transactionRequests => (transactionRequests, callContext))
}
override def getTransactionRequestStatuses(): Box[TransactionRequestStatus] = {
for {
transactionRequestStatuses <- getTransactionRequestStatusesImpl()
} yield transactionRequestStatuses
}
override def getTransactionRequestImpl(transactionRequestId: TransactionRequestId, callContext: Option[CallContext]): Box[(TransactionRequest, Option[CallContext])] =
TransactionRequests.transactionRequestProvider.vend.getTransactionRequest(transactionRequestId).map(transactionRequest => (transactionRequest, callContext))

5
obp-commons/src/main/scala/com/openbankproject/commons/dto/JsonsTransfer.scala
View File

@ -1159,11 +1159,6 @@ case class InBoundGetTransactionRequestStatuses(status: Status, data: Transactio
override val inboundAdapterCallContext: InboundAdapterCallContext = InboundAdapterCallContext()
}
case class OutBoundGetTransactionRequestStatusesImpl() extends TopicTrait
case class InBoundGetTransactionRequestStatusesImpl(status: Status, data: TransactionRequestStatusCommons) extends InBoundTrait[TransactionRequestStatusCommons] {
override val inboundAdapterCallContext: InboundAdapterCallContext = InboundAdapterCallContext()
}
case class OutBoundGetTransactionRequestsImpl(fromAccount: BankAccount) extends TopicTrait
case class InBoundGetTransactionRequestsImpl(status: Status, data: List[TransactionRequest]) extends InBoundTrait[List[TransactionRequest]] {
override val inboundAdapterCallContext: InboundAdapterCallContext = InboundAdapterCallContext()