From 939a49c3462127043bc334c19798ab81028d2f6f Mon Sep 17 00:00:00 2001 From: Simon Redfern Date: Mon, 28 Jun 2021 13:30:40 +0200 Subject: [PATCH 1/4] adding Hola App log trace --- obp-api/src/main/scala/code/api/util/Glossary.scala | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/obp-api/src/main/scala/code/api/util/Glossary.scala b/obp-api/src/main/scala/code/api/util/Glossary.scala index 857513d5a..5e2a581a4 100644 --- a/obp-api/src/main/scala/code/api/util/Glossary.scala +++ b/obp-api/src/main/scala/code/api/util/Glossary.scala @@ -2037,6 +2037,19 @@ object Glossary { """) + + glossaryItems += GlossaryItem( + title = "Hola App log trace", + description = + s""" + Please see: + [OBP Hola App Log Trace](https://github.com/OpenBankProject/OBP-API/wiki/Log-trace-of-the-Hola-App-performing-Georgian-flavour-of-Berlin-Group-authentication,-consent-generation-and-consuming-Berlin-Group-Account,-Balance-and-Transaction-resources) + """) + + + + + /////////////////////////////////////////////////////////////////// // NOTE! Some glossary items are generated in ExampleValue.scala ////////////////////////////////////////////////////////////////// From 98c5503c1c79c82f67838a105169106d60ab76e4 Mon Sep 17 00:00:00 2001 From: Simon Redfern Date: Tue, 29 Jun 2021 13:34:27 +0200 Subject: [PATCH 2/4] authUser.skipEmailValidation now defaults to false --- obp-api/src/main/scala/code/model/dataAccess/AuthUser.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/obp-api/src/main/scala/code/model/dataAccess/AuthUser.scala b/obp-api/src/main/scala/code/model/dataAccess/AuthUser.scala index 573647bd9..11dee56f4 100644 --- a/obp-api/src/main/scala/code/model/dataAccess/AuthUser.scala +++ b/obp-api/src/main/scala/code/model/dataAccess/AuthUser.scala @@ -421,8 +421,8 @@ import net.liftweb.util.Helpers._ override def fieldOrder = List(id, firstName, lastName, email, username, password, provider) override def signupFields = List(firstName, lastName, email, username, password) - // If we want to validate email addresses set this to false - override def skipEmailValidation = APIUtil.getPropsAsBoolValue("authUser.skipEmailValidation", true) + // To force validation of email addresses set this to false (default as of 29 June 2021) + override def skipEmailValidation = APIUtil.getPropsAsBoolValue("authUser.skipEmailValidation", false) override def loginXhtml = { val loginXml = Templates(List("templates-hidden","_login")).map({ From ce8d171224346cc1b9d20e5db1b25972afc9add5 Mon Sep 17 00:00:00 2001 From: Simon Redfern Date: Tue, 29 Jun 2021 13:37:55 +0200 Subject: [PATCH 3/4] authUser.skipEmailValidation default in release notes --- release_notes.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/release_notes.md b/release_notes.md index 17815a214..e7e900a9f 100644 --- a/release_notes.md +++ b/release_notes.md @@ -2,7 +2,8 @@ ### Most recent changes at top of file ``` -Date Commit Action +Date Commit Action +29/06/2021 98c5503c Existing Props authUser.skipEmailValidation now defaults to false (i.e. we now force email validation by default) 14/03/2021 e29001e2 Added props: webui_login_page_instruction_title, default is 'Log on to the Open Bank Project API'. The clients can customise the login page instraction title. 13/03/2021 3c9880a9 Added props: featured_api_collection_ids, default is Empty. From 870e4008550f29cebe485c07e09f35a6f1096f45 Mon Sep 17 00:00:00 2001 From: Simon Redfern Date: Tue, 29 Jun 2021 13:38:22 +0200 Subject: [PATCH 4/4] todo/glossary Hola App log trace --- obp-api/src/main/scala/code/api/util/Glossary.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/obp-api/src/main/scala/code/api/util/Glossary.scala b/obp-api/src/main/scala/code/api/util/Glossary.scala index 1e9a7c07f..7c3f574f7 100644 --- a/obp-api/src/main/scala/code/api/util/Glossary.scala +++ b/obp-api/src/main/scala/code/api/util/Glossary.scala @@ -2070,7 +2070,7 @@ object Glossary { """) - +// TODO put the following wiki text here in source code with soft coded hosts etc. The problem is the text is currently too long glossaryItems += GlossaryItem( title = "Hola App log trace", description =