From ade36321ff37c4b801e73d848247c49ccd8c483b Mon Sep 17 00:00:00 2001
From: Hongwei <hongwei@tesobe.com>
Date: Thu, 20 Feb 2025 16:13:34 +0100
Subject: [PATCH] refactor/tweaked the variable names

---
 .../ResourceDocsAPIMethods.scala              | 20 +++++++++----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/obp-api/src/main/scala/code/api/ResourceDocs1_4_0/ResourceDocsAPIMethods.scala b/obp-api/src/main/scala/code/api/ResourceDocs1_4_0/ResourceDocsAPIMethods.scala
index fc2935f7d..ff0d92a9a 100644
--- a/obp-api/src/main/scala/code/api/ResourceDocs1_4_0/ResourceDocsAPIMethods.scala
+++ b/obp-api/src/main/scala/code/api/ResourceDocs1_4_0/ResourceDocsAPIMethods.scala
@@ -519,7 +519,7 @@ trait ResourceDocsAPIMethods extends MdcLoggable with APIMethods220 with APIMeth
                 case Some(STATIC) => {
                   val cacheValueFromRedis = Caching.getStaticResourceDocCache(cacheKey)
 
-                  val dynamicDocs: Box[JValue] =
+                  val staticDocs: Box[JValue] =
                     if (cacheValueFromRedis.isDefined) {
                       Full(json.parse(cacheValueFromRedis.get))
                     } else {
@@ -530,12 +530,12 @@ trait ResourceDocsAPIMethods extends MdcLoggable with APIMethods220 with APIMeth
                       Full(resourceDocJsonJValue)
                     }
 
-                  Future(dynamicDocs.map(successJsonResponse(_)))
+                  Future(staticDocs.map(successJsonResponse(_)))
                 }
                 case _ => {
                   val cacheValueFromRedis = Caching.getAllResourceDocCache(cacheKey)
 
-                  val dynamicDocs: Box[JValue] =
+                  val bothStaticAndDyamicDocs: Box[JValue] =
                     if (cacheValueFromRedis.isDefined) {
                       Full(json.parse(cacheValueFromRedis.get))
                     } else {
@@ -546,7 +546,7 @@ trait ResourceDocsAPIMethods extends MdcLoggable with APIMethods220 with APIMeth
                       Full(resourceDocJsonJValue)
                     }
 
-                  Future(dynamicDocs.map(successJsonResponse(_)))
+                  Future(bothStaticAndDyamicDocs.map(successJsonResponse(_)))
                 }
               }
           }
@@ -715,13 +715,11 @@ trait ResourceDocsAPIMethods extends MdcLoggable with APIMethods220 with APIMeth
             swaggerJValue <- NewStyle.function.tryons(s"$UnknownError Can not convert internal swagger file.", 400, cc.callContext) {
               val cacheValueFromRedis = Caching.getStaticSwaggerDocCache(cacheKey)
 
-              val dynamicDocs: JValue =
-                if (cacheValueFromRedis.isDefined) {
-                  json.parse(cacheValueFromRedis.get)
-                } else {
-                  convertResourceDocsToSwaggerJvalueAndSetCache(cacheKey, requestedApiVersionString, resourceDocsJsonFiltered)
-                }
-                dynamicDocs
+              if (cacheValueFromRedis.isDefined) {
+                json.parse(cacheValueFromRedis.get)
+              } else {
+                convertResourceDocsToSwaggerJvalueAndSetCache(cacheKey, requestedApiVersionString, resourceDocsJsonFiltered)
+              }
             }
           } yield {
             (swaggerJValue, HttpCode.`200`(cc.callContext))