artin/OBP-API
1
0
Fork 0
mirror of https://github.com/OpenBankProject/OBP-API.git synced 2026-02-06 19:16:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added TODOs around firehose views.

Browse Source
This commit is contained in:
Simon Redfern 2019-02-23 00:38:45 +01:00
parent e1944cc6f9
commit 770914c6ae
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/scala/code/api/v3_0_0/APIMethods300.scala
View File

@ -465,6 +465,8 @@ trait APIMethods300 {
|
|To be shown on the list, each Account must have a firehose View linked to it.
|
|A firehose view has is_firehose = true
|
|For VIEW_ID try 'owner'
|
|

10
src/main/scala/code/views/MapperViews.scala
View File

@ -588,7 +588,7 @@ object MapperViews extends Views with MdcLoggable {
def unsavedOwnerView(bankId : BankId, accountId: AccountId, description: String) : ViewImpl = {
create
.isSystem_(true)
.isFirehose_(true)
.isFirehose_(true) // TODO This should be set to false. i.e. Firehose views should be separate
.bankPermalink(bankId.value)
.accountPermalink(accountId.value)
.name_("Owner")
@ -674,7 +674,7 @@ object MapperViews extends Views with MdcLoggable {
def unsavedFirehoseView(bankId : BankId, accountId: AccountId, description: String) : ViewImpl = {
create
.isSystem_(true)
.isFirehose_(true)
.isFirehose_(true) // Of the autogenerated views, only firehose should be firehose (except public)
.bankPermalink(bankId.value)
.accountPermalink(accountId.value)
.name_("Firehose")
@ -770,7 +770,7 @@ object MapperViews extends Views with MdcLoggable {
def unsavedDefaultPublicView(bankId : BankId, accountId: AccountId, description: String) : ViewImpl = {
create.
isSystem_(true).
isFirehose_(true).
isFirehose_(true). // This View is public so it might as well be firehose too.
name_("Public").
description_(description).
permalink_("public").
@ -867,7 +867,7 @@ object MapperViews extends Views with MdcLoggable {
def unsavedDefaultAccountantsView(bankId : BankId, accountId: AccountId, description: String) : ViewImpl = {
create.
isSystem_(true).
isFirehose_(true).
isFirehose_(true). // TODO This should be set to false. i.e. Firehose views should be separate
name_("Accountant"). // Use the singular form
description_(description).
permalink_("accountant"). // Use the singular form
@ -963,7 +963,7 @@ Auditors
def unsavedDefaultAuditorsView(bankId : BankId, accountId: AccountId, description: String) : ViewImpl = {
create.
isSystem_(true).
isFirehose_(true).
isFirehose_(true). // TODO This should be set to false. i.e. Firehose views should be separate
name_("Auditor"). // Use the singular form
description_(description).
permalink_("auditor"). // Use the singular form