artin/OBP-API
1
0
Fork 0
mirror of https://github.com/OpenBankProject/OBP-API.git synced 2026-02-06 17:17:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix error code 400 to 403

Browse Source
This commit is contained in:
Marko Milić 2020-04-01 14:45:51 +02:00
parent 08f32808d9
commit 69f4762cf4
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
obp-api/src/main/scala/code/api/util/APIUtil.scala
View File

@ -456,8 +456,13 @@ object APIUtil extends MdcLoggable with CustomJsonFormats{
}
def errorJsonResponse(message : String = "error", httpCode : Int = 400)(implicit headers: CustomResponseHeaders = CustomResponseHeaders(Nil)) : JsonResponse = {
val forbidden = message.contains(UserHasMissingRoles) ||
message.contains(UserNoPermissionAccessView) ||
message.contains(UserHasMissingRoles) ||
message.contains(UserNotSuperAdminOrMissRole) ||
message.contains(ConsumerHasMissingRoles)
val code =
message.contains(UserHasMissingRoles) match {
forbidden match {
case true =>
403
case _ =>

4
obp-api/src/test/scala/code/api/v3_1_0/TransactionRequestTest.scala
View File

@ -82,8 +82,8 @@ class TransactionRequestTest extends V310ServerSetup {
v3_1_0_Request / "banks" / bankId / "accounts" / account.accountId.value
/ Constant.CUSTOM_OWNER_VIEW_ID / "transaction-requests").GET <@(user2)
val response310 = makeGetRequest(request310)
Then("We should get a 400")
response310.code should equal(400)
Then("We should get a 403")
response310.code should equal(403)
And("error should be " + UserNoPermissionAccessView)
response310.body.extract[ErrorMessage].message should equal (UserNoPermissionAccessView)
}