From 69b29b9b6d5836ffaca0c4b2b57e0374b9de1a6d Mon Sep 17 00:00:00 2001 From: hongwei Date: Wed, 3 Aug 2022 10:05:44 +0200 Subject: [PATCH] refactor/rename to userAuthContextUpdateRequest.challenge.ttl.seconds --- obp-api/src/main/resources/props/sample.props.template | 2 +- obp-api/src/main/scala/code/api/util/APIUtil.scala | 2 +- .../code/context/MappedUserAuthContextUpdateProvider.scala | 4 ++-- release_notes.md | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/obp-api/src/main/resources/props/sample.props.template b/obp-api/src/main/resources/props/sample.props.template index 0f298bf62..1c7da5e7b 100644 --- a/obp-api/src/main/resources/props/sample.props.template +++ b/obp-api/src/main/resources/props/sample.props.template @@ -245,7 +245,7 @@ token_expiration_weeks=4 transactionRequest.challenge.ttl.seconds=600 ## auth context update request challenge answer timeout,default is 600 seconds/10 minutes -authContextUpdateRequest.challenge.ttl.seconds=600 +userAuthContextUpdateRequest.challenge.ttl.seconds=600 # the allowed attempts to answer the same transactionRequest Challenge, default is 3 times #answer_transactionRequest_challenge_allowed_attempts=3 diff --git a/obp-api/src/main/scala/code/api/util/APIUtil.scala b/obp-api/src/main/scala/code/api/util/APIUtil.scala index d250e15a8..3df702411 100644 --- a/obp-api/src/main/scala/code/api/util/APIUtil.scala +++ b/obp-api/src/main/scala/code/api/util/APIUtil.scala @@ -4203,7 +4203,7 @@ object APIUtil extends MdcLoggable with CustomJsonFormats{ """.stripMargin val transactionRequestChallengeTtl = APIUtil.getPropsAsLongValue("transactionRequest.challenge.ttl.seconds", 600) - val authContextUpdateRequestChallengeTtl = APIUtil.getPropsAsLongValue("authContextUpdateRequest.challenge.ttl.seconds", 600) + val userAuthContextUpdateRequestChallengeTtl = APIUtil.getPropsAsLongValue("userAuthContextUpdateRequest.challenge.ttl.seconds", 600) val obpErrorMessageCodeRegex = "^(OBP-\\d+):" diff --git a/obp-api/src/main/scala/code/context/MappedUserAuthContextUpdateProvider.scala b/obp-api/src/main/scala/code/context/MappedUserAuthContextUpdateProvider.scala index 9499547d1..497f0695d 100644 --- a/obp-api/src/main/scala/code/context/MappedUserAuthContextUpdateProvider.scala +++ b/obp-api/src/main/scala/code/context/MappedUserAuthContextUpdateProvider.scala @@ -53,7 +53,7 @@ object MappedUserAuthContextUpdateProvider extends UserAuthContextUpdateProvider MappedUserAuthContextUpdate.find(By(MappedUserAuthContextUpdate.mUserAuthContextUpdateId, consentId)) match { case Full(consent) => val createDateTime = consent.createdAt.get - val challengeTTL : Long = Helpers.seconds(APIUtil.authContextUpdateRequestChallengeTtl) + val challengeTTL : Long = Helpers.seconds(APIUtil.userAuthContextUpdateRequestChallengeTtl) val expiredDateTime: Long = createDateTime.getTime+challengeTTL val currentTime: Long = Platform.currentTime @@ -66,7 +66,7 @@ object MappedUserAuthContextUpdateProvider extends UserAuthContextUpdateProvider Full(consent) } else{ - Failure(s"${ErrorMessages.OneTimePasswordExpired} Current expiration time is ${APIUtil.authContextUpdateRequestChallengeTtl} seconds") + Failure(s"${ErrorMessages.OneTimePasswordExpired} Current expiration time is ${APIUtil.userAuthContextUpdateRequestChallengeTtl} seconds") } case Empty => Empty ?~! ErrorMessages.UserAuthContextUpdateNotFound diff --git a/release_notes.md b/release_notes.md index 7e0ad5f0d..28d09717a 100644 --- a/release_notes.md +++ b/release_notes.md @@ -3,7 +3,7 @@ ### Most recent changes at top of file ``` Date Commit Action -02/08/2022 7b06563f added new props `authContextUpdateRequest.challenge.ttl.seconds`, default is 600 seconds. +02/08/2022 7b06563f added new props `userAuthContextUpdateRequest.challenge.ttl.seconds`, default is 600 seconds. 01/08/2022 d94687d6 added new props `answer_transactionRequest_challenge_allowed_attempts`, default is 3 . 03/05/2022 5fe70270 added new props `transactionRequest.challenge.ttl.seconds`, default is 600 seconds. 31/03/2022 a0262c3f added new value SIMPLE to props `transactionRequests_supported_types`