fixed the create counterpart test

src/main/scala/code/api/v2_1_0/APIMethods210.scala

@@ -362,7 +362,7 @@ trait APIMethods210 {
                     // Following 7 lines: just transfer the details body, add Bank_Id and Account_Id in the Detail part.
                     toBankId <- Full(BankId(toCounterparty.otherBankId ))
                     toAccountId <- Full(AccountId(toCounterparty.otherAccountId))
-                    toAccountProvider <- Full(AccountId(toCounterparty.otherAccountProvider))
+                    toAccountProvider <- Full(toCounterparty.otherAccountProvider)
                     // Use toAccountProvider to determine how we validate the toBank and toAccount.
                     // i.e. Only validate toBankId and toAccountId if the toAccountProvider is OBP
                     // i.e. if toAccountProvider is OBP we can expect the account to exist locally.

src/test/scala/code/api/LocalMappedConnectorTestSetup.scala

@@ -35,8 +35,9 @@ trait LocalMappedConnectorTestSetup extends TestConnectorSetupWithStandardPermis
       mOtherBankId(bankId).
       mOtherAccountId(accountId).
       mIsBeneficiary(isBeneficiary).
-      mOtherAccountRoutingScheme("IBAN").
-    saveMe
+      mOtherAccountRoutingScheme("IBAN"). //it is for test, so set it the default value
+      mOtherAccountProvider("OBP"). //it is for test, so set it the default value
+      saveMe
   }
 
 // TODO: Should return an option or box so can test if the insert succeeded