artin/OBP-API
1
0
Fork 0
mirror of https://github.com/OpenBankProject/OBP-API.git synced 2026-02-06 15:27:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2169 from hongwei1/refactor/removeSessionIpAddressCheck

Browse Source 
refactor/remove the check for session Ip
This commit is contained in:
Simon Redfern 2023-01-20 13:32:12 +01:00 committed by GitHub
commit 291e4c8af5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
obp-api/src/main/resources/props/sample.props.template
View File

@ -1211,4 +1211,7 @@ user_account_is_validated = false
retain_archive_metrics_days = 1095
# Defines the number of days we keep rows in the table "Metric" former "MappedMetric"
retain_metrics_days = 60
retain_metrics_days = 60
#if same session used for different ip address, we can show this warning, default is false.
show_ip_address_change_warning=false

3
obp-api/src/main/scala/code/snippet/WebUI.scala
View File

@ -123,10 +123,11 @@ class WebUI extends MdcLoggable{
if (firstKnownIPAddress.isEmpty)
firstKnownIPAddress(getRemoteIpAddress())
val showIpAddressChangeWarning = APIUtil.getPropsAsBoolValue("show_ip_address_change_warning",false)
def concurrentLoginsCookiesCheck = {
updateIPaddressEachtime(getRemoteIpAddress())
if(!firstKnownIPAddress.isEmpty & !firstKnownIPAddress.get.equals(updateIPaddressEachtime.get)) {
if(showIpAddressChangeWarning && !firstKnownIPAddress.isEmpty && !firstKnownIPAddress.get.equals(updateIPaddressEachtime.get)) {
log.warn("Warning! The Session ID is used in another IP address, it maybe be stolen or you change the network. Please check it first ! ")
S.error("Warning! Another IP address is also using your Session ID. Did you change your network? ")
}

1
release_notes.md
View File

@ -3,6 +3,7 @@
### Most recent changes at top of file
```
Date Commit Action
20/01/2023 c26226e6 Added props show_ip_address_change_warning, default is false.
29/09/2022 eaa32f41 Added props excluded.response.behaviour, default is false. Set it to true to activate the props: excluded.response.field.values. Note: excluded.response.field.values can also be activated on a per call basis by the url param ?exclude-optional-fields=true
07/09/2022 53564924 renamed props `language_tag` to `default_locale`, default is en_GB.
08/08/2022 1ff7bf0a removed props `meeting.tokbox_enabled`, `meeting.tokbox_api_key` and `meeting.tokbox_api_secret`.