artin/OBP-API
1
0
Fork 0
mirror of https://github.com/OpenBankProject/OBP-API.git synced 2026-02-06 13:07:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor/removed getEmptyBankAccount

Browse Source
This commit is contained in:
hongwei 2024-10-21 15:33:54 +02:00
parent ff7e3d8078
commit 2466f44d1c
4 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
obp-api/src/main/scala/code/bankconnectors/Connector.scala
View File

@ -558,15 +558,7 @@ trait Connector extends MdcLoggable {
def checkBankAccountExistsLegacy(bankId : BankId, accountId : AccountId, callContext: Option[CallContext] = None) : Box[(BankAccount, Option[CallContext])]= Failure(setUnimplementedError(nameOf(checkBankAccountExistsLegacy _)))
def checkBankAccountExists(bankId : BankId, accountId : AccountId, callContext: Option[CallContext] = None) : OBPReturnType[Box[(BankAccount)]] = Future {(Failure(setUnimplementedError(nameOf(checkBankAccountExists _))), callContext)}
/**
* This method is just return an empty account to AccountType.
* It is used for SEPA, Counterparty empty toAccount
*
* @return empty bankAccount
*/
def getEmptyBankAccount(): Box[BankAccount]= Failure(setUnimplementedError(nameOf(getEmptyBankAccount _)))
def getCounterpartyFromTransaction(bankId: BankId, accountId: AccountId, counterpartyId: String): Box[Counterparty] = {
val transactions = getTransactionsLegacy(bankId, accountId ,None).map(_._1).toList.flatten
val counterparties = for {

1
obp-api/src/main/scala/code/bankconnectors/ConnectorBuilderUtil.scala
View File

@ -410,7 +410,6 @@ object ConnectorBuilderUtil {
//"getPhysicalCardsForBankLegacy", // should not generate for Legacy methods
//"getBranchLegacy", // should not generate for Legacy methods
//"getAtmLegacy", // should not generate for Legacy methods
"getEmptyBankAccount",
"getCounterpartyFromTransaction",
"getCounterpartiesFromTransaction",
).distinct

5
obp-api/src/main/scala/code/bankconnectors/LocalMappedConnector.scala
View File

@ -1224,10 +1224,7 @@ object LocalMappedConnector extends Connector with MdcLoggable {
}
override def getEmptyBankAccount(): Box[BankAccount] = {
Full(new MappedBankAccount())
}
/**
* This is used for create or update the special bankAccount for COUNTERPARTY stuff (toAccountProvider != "OBP") and (Connector = Kafka)
* details in createTransactionRequest - V210 ,case COUNTERPARTY.toString

4
obp-commons/src/main/scala/com/openbankproject/commons/dto/JsonsTransfer.scala
View File

@ -1024,10 +1024,6 @@ case class InBoundDynamicEntityProcessDoc (inboundAdapterCallContext: InboundAda
case class OutBoundCreateChallenges(outboundAdapterCallContext: OutboundAdapterCallContext, bankId: BankId, accountId: AccountId, userIds: List[String], transactionRequestType: TransactionRequestType, transactionRequestId: String, scaMethod: Option[StrongCustomerAuthentication.SCA]) extends TopicTrait
case class InBoundCreateChallenges(inboundAdapterCallContext: InboundAdapterCallContext, status: Status, data: List[String]) extends InBoundTrait[List[String]]
case class OutBoundGetEmptyBankAccount() extends TopicTrait
case class InBoundGetEmptyBankAccount(status: Status, data: BankAccountCommons) extends InBoundTrait[BankAccountCommons] {
override val inboundAdapterCallContext: InboundAdapterCallContext = InboundAdapterCallContext()
}
case class OutBoundGetCounterpartyFromTransaction(bankId: BankId, accountId: AccountId, counterpartyId: String) extends TopicTrait
case class InBoundGetCounterpartyFromTransaction(status: Status, data: Counterparty) extends InBoundTrait[Counterparty] {