artin/OBP-API
1
0
Fork 0
mirror of https://github.com/OpenBankProject/OBP-API.git synced 2026-02-06 13:07:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Breaking Role Name changes. CanGetCustomersAtAnyBank ->

Browse Source 
CanGetCustomersAtAllBanks and CanGetCustomers ->
CanGetCustomersAtOneBank
This commit is contained in:
simonredfern 2025-11-18 00:23:10 +01:00
parent dda1432132
commit 0dec283247
6 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
obp-api/src/main/scala/code/api/ResourceDocs1_4_0/SwaggerDefinitionsJSON.scala
View File

@ -4656,7 +4656,7 @@ object SwaggerDefinitionsJSON {
bank_id = bankIdExample.value
)
lazy val canGetCustomersJson = ApiRole.canGetCustomers
lazy val canGetCustomersJson = ApiRole.canGetCustomersAtOneBank
lazy val cardAttributeCommons = CardAttributeCommons(
bankId = Some(BankId(bankIdExample.value)),

8
obp-api/src/main/scala/code/api/util/ApiRole.scala
View File

@ -84,14 +84,14 @@ object ApiRole extends MdcLoggable{
case class CanSearchMetrics(requiresBankId: Boolean = false) extends ApiRole
lazy val canSearchMetrics = CanSearchMetrics()
case class CanGetCustomersAtAnyBank(requiresBankId: Boolean = false) extends ApiRole
lazy val canGetCustomersAtAnyBank = CanGetCustomersAtAnyBank()
case class CanGetCustomersAtAllBanks(requiresBankId: Boolean = false) extends ApiRole
lazy val canGetCustomersAtAllBanks = CanGetCustomersAtAllBanks()
case class CanGetCustomersMinimalAtAnyBank(requiresBankId: Boolean = false) extends ApiRole
lazy val canGetCustomersMinimalAtAnyBank = CanGetCustomersMinimalAtAnyBank()
case class CanGetCustomers(requiresBankId: Boolean = true) extends ApiRole
lazy val canGetCustomers = CanGetCustomers()
case class CanGetCustomersAtOneBank(requiresBankId: Boolean = true) extends ApiRole
lazy val canGetCustomersAtOneBank = CanGetCustomersAtOneBank()
case class CanGetCustomersMinimal(requiresBankId: Boolean = true) extends ApiRole
lazy val canGetCustomersMinimal = CanGetCustomersMinimal()

2
obp-api/src/main/scala/code/api/v4_0_0/APIMethods400.scala
View File

@ -6857,7 +6857,7 @@ trait APIMethods400 extends MdcLoggable {
UnknownError
),
List(apiTagCustomer, apiTagUser),
Some(List(canGetCustomersAtAnyBank))
Some(List(canGetCustomersAtAllBanks))
)
lazy val getCustomersAtAnyBank: OBPEndpoint = {
case "customers" :: Nil JsonGet _ => { cc =>

2
obp-api/src/main/scala/code/api/v5_0_0/APIMethods500.scala
View File

@ -1609,7 +1609,7 @@ trait APIMethods500 {
UnknownError
),
List(apiTagCustomer, apiTagUser),
Some(List(canGetCustomers))
Some(List(canGetCustomersAtOneBank))
)
lazy val getCustomersAtOneBank : OBPEndpoint = {

2
obp-api/src/main/scala/code/api/v6_0_0/APIMethods600.scala
View File

@ -1129,7 +1129,7 @@ trait APIMethods600 {
UnknownError
),
List(apiTagCustomer, apiTagUser),
Some(List(canGetCustomers))
Some(List(canGetCustomersAtOneBank))
)
lazy val getCustomersAtOneBank : OBPEndpoint = {

6
obp-api/src/test/scala/code/api/v4_0_0/CustomerTest.scala
View File

@ -91,14 +91,14 @@ class CustomerTest extends V400ServerSetup with PropsReset{
val response = makeGetRequest(request)
Then("We should get a 403")
response.code should equal(403)
val errorMsg = UserHasMissingRoles + canGetCustomersAtAnyBank
val errorMsg = UserHasMissingRoles + canGetCustomersAtAllBanks
And("error should be " + errorMsg)
val errorMessage = response.body.extract[ErrorMessage].message
errorMessage contains (UserHasMissingRoles) should be (true)
errorMessage contains (canGetCustomersAtAnyBank.toString()) should be (true)
errorMessage contains (canGetCustomersAtAllBanks.toString()) should be (true)
}
scenario("We will call the endpoint with a user credentials and a proper role", ApiEndpoint1, VersionOfApi) {
Entitlement.entitlement.vend.addEntitlement("", resourceUser1.userId, CanGetCustomersAtAnyBank.toString)
Entitlement.entitlement.vend.addEntitlement("", resourceUser1.userId, CanGetCustomersAtAllBanks.toString)
When(s"We make a request $VersionOfApi")
val request = (v4_0_0_Request / "customers").GET <@(user1)
val response = makeGetRequest(request)