artin/OBP-API
1
0
Fork 0
mirror of https://github.com/OpenBankProject/OBP-API.git synced 2026-02-06 16:36:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

bugfix: Fixing malformed example in Dynamic Entity diagnostics that

Browse Source 
caused a problem!
This commit is contained in:
simonredfern 2025-11-17 23:23:53 +01:00
parent c7b65538b5
commit 00d6b792c8
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
obp-api/src/main/scala/code/api/v6_0_0/APIMethods600.scala
View File

@ -440,7 +440,7 @@ trait APIMethods600 {
|
|**What It Checks:**
|This endpoint analyzes all dynamic entities (both system and bank level) for:
|* Boolean fields with invalid example values (e.g., `"{"tok"` instead of `"true"` or `"false"`)
|* Boolean fields with invalid example values (e.g., actual JSON booleans or invalid strings instead of `"true"` or `"false"`)
|* Malformed JSON in field definitions
|* Fields that cannot be converted to their declared types
|* Other validation issues that cause Swagger generation to fail
@ -469,8 +469,8 @@ trait APIMethods600 {
| "entity_name": "Customer",
| "bank_id": "gh.29.uk",
| "field_name": "is_active",
| "example_value": "{"tok",
| "error_message": "Boolean field has invalid example value. Expected 'true' or 'false', got: '{"tok'"
| "example_value": "malformed_value",
| "error_message": "Boolean field has invalid example value. Expected 'true' or 'false', got: 'malformed_value'"
|}
|```
|
@ -488,8 +488,8 @@ trait APIMethods600 {
entity_name = "MyEntity",
bank_id = "gh.29.uk",
field_name = "is_active",
example_value = "{\"tok",
error_message = "Boolean field has invalid example value. Expected 'true' or 'false', got: '{\"tok'"
example_value = "malformed_value",
error_message = "Boolean field has invalid example value. Expected 'true' or 'false', got: 'malformed_value'"
)
),
total_issues = 1

12
obp-commons/src/main/scala/com/openbankproject/commons/model/enums/Enumerations.scala
View File

@ -194,7 +194,17 @@ sealed trait DynamicEntityFieldType extends EnumValue {
object DynamicEntityFieldType extends OBPEnumeration[DynamicEntityFieldType]{
object number extends Value{val jValueType = classOf[JDouble]}
object integer extends Value{val jValueType = classOf[JInt]}
object boolean extends Value{val jValueType = classOf[JBool]}
object boolean extends Value {
val jValueType = classOf[JString]
override def isJValueValid(jValue: JValue): Boolean = {
super.isJValueValid(jValue) && {
val value = jValue.asInstanceOf[JString].s
val lowerValue = value.toLowerCase
lowerValue == "true" || lowerValue == "false"
}
}
override def wrongTypeMsg: String = s"""the value's type should be string "true" or "false"."""
}
object string extends Value{
val jValueType = classOf[JString]